Skip to content
  • John Baldwin's avatar
    Move mksubr from kdump into libsysdecode. · 9289f547
    John Baldwin authored
    Restructure this script so that it generates a header of tables instead
    of a source file.  The tables are included in a flags.c source file which
    provides functions to decode various system call arguments.
    
    For functions that decode an enumeration, the function returns a pointer
    to a string for known values and NULL for unknown values.
    
    For functions that do more complex decoding (typically of a bitmask), the
    function accepts a pointer to a FILE object (open_memstream() can be used
    as a string builder) to which decoded values are written.  If the
    function operates on a bitmask, the function returns true if any bits
    were decoded or false if the entire value was valid.  Additionally, the
    third argument accepts a pointer to a value to which any undecoded bits
    are stored.  This pointer can be NULL if the caller doesn't care about
    remaining bits.
    
    Convert kdump over to using decoder functions from libsysdecode instead of
    mksubr.  truss also uses decoders from libsysdecode instead of private
    lookup tables, though lookup tables for objects not decoded by kdump remain
    in truss for now.  Eventually most of these tables should move into
    libsysdecode as the automated table generation approach from mksubr is
    less stale than the static tables in truss.
    
    Some changes have been made to truss and kdump output:
    - The flags passed to open() are now properly decoded in that one of
      O_RDONLY, O_RDWR, O_WRONLY, or O_EXEC is always included in a decoded
      mask.
    - Optional arguments to open(), openat(), and fcntl() are only printed
      in kdump if they exist (e.g. the mode is only printed for open() if
      O_CREAT is set in the flags).
    - Print argument to F_GETLK/SETLK/SETLKW in kdump as a pointer, not int.
    - Include all procctl() commands.
    - Correctly decode pipe2() flags in truss by not assuming full
      open()-like flags with O_RDONLY, etc.
    - Decode file flags passed to *chflags() as file flags (UF_* and SF_*)
      rather than as a file mode.
    - Fix decoding of quotactl() commands by splitting out the two command
      components instead of assuming the raw command value matches the
      primary command component.
    
    In addition, truss and kdump now build without triggering any warnings.
    All of the sysdecode manpages now include the required headers in the
    synopsis.
    
    Reviewed by:	kib (several older versions), wblock (manpages)
    MFC after:	2 months
    Differential Revision:	https://reviews.freebsd.org/D7847
    9289f547