Commit d4e6557b authored by Conrad Meyer's avatar Conrad Meyer
Browse files

ffs: softdep_disk_write_complete: Quiesce spurious Coverity warning

Coverity cannot determine that handle_written_indirdep() does not access
uninitialized 'sbp' when flags argument is zero.

So, simply move the initialization slightly sooner to silence the warning.

No functional change.

Reported by:	Coverity
Sponsored by:	Dell EMC Isilon
parent 7feea407
......@@ -10984,6 +10984,8 @@ softdep_disk_write_complete(bp)
if (ump == NULL)
return;
sbp = NULL;
/*
* If an error occurred while doing the write, then the data
* has not hit the disk and the dependencies cannot be processed.
......@@ -11026,7 +11028,6 @@ softdep_disk_write_complete(bp)
/*
* Ump SU lock must not be released anywhere in this code segment.
*/
sbp = NULL;
owk = NULL;
while ((wk = LIST_FIRST(&bp->b_dep)) != NULL) {
WORKLIST_REMOVE(wk);
......
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment