1. 09 Nov, 2018 25 commits
  2. 08 Nov, 2018 15 commits
    • Kristof Provost's avatar
      pf tests: Test PR 183198 · 55177f18
      Kristof Provost authored
      Create a table which is only used inside an anchor, ensure that the
      table exists.
      
      PR:		183198
      MFC after:	2 weeks
      55177f18
    • Kristof Provost's avatar
      pf: Prevent tables referenced by rules in anchors from getting disabled. · 87e4ca37
      Kristof Provost authored
      PR:		183198
      Obtained from:	OpenBSD
      MFC after:	2 weeks
      87e4ca37
    • Kristof Provost's avatar
      pfctl: Populate ifname in ifa_lookup() · 0f9e47a9
      Kristof Provost authored
      pfctl_adjust_skip_ifaces() relies on this name.
      
      MFC after:	2 weeks
      0f9e47a9
    • Justin Hibbits's avatar
      powerpc64: Fix "show spr" command on ELFv2 kernels · 8f04c0c0
      Justin Hibbits authored
      Summary: When compiling for ELFv2, it is necessary to adjust the offset to
      get_spr and factor in the function prologue to ensure the correct instruction is
      being edited.
      
      Test Plan:
      Before:
      ```
      db> show spr 110
      KDB: reentering
      KDB: stack backtrace:
      0xc008000020fb96e0: at 0xc000000002bb2e34 = kdb_backtrace+0x68
      0xc008000020fb97f0: at 0xc000000002bb3798 = kdb_reenter+0x54
      0xc008000020fb9860: at 0xc000000002f87090 = trap+0x4e4
      0xc008000020fb9990: at 0xc000000002f78a60 = powerpc_interrupt+0x110
      0xc008000020fb9a20: kernel trap 0xe40 by 0xc000000002401978 = get_spr+0x8: srr1=0x9000000000001032
                  r1=0xc008000020fb9cd0 cr=0x80009438 xer=0x20040000 ctr=0xc000000002f7b40c r2=0xc0000000037fd000
      saved LR(0xfffffffffffffffb) is invalid.
      ```
      
      After:
      
      ```
      db> show spr 110
      SPR 272(110): c000000003cae900
      ```
      
      Submitted by:	git_bdragon.rtk0.net
      Differential Revision: https://reviews.freebsd.org/D17813
      8f04c0c0
    • Justin Hibbits's avatar
      powerpc/powernv: Restrict the busdma tag to only POWER8 · ad39591a
      Justin Hibbits authored
      It seems this tag is causing problems on POWER9 systems.  Since no POWER9 user
      has encountered the problem fixed by r339589 just restrict it to POWER8 for now.
      A better fix will likely be to update powerpc/busdma_machdep.c to handle the
      window correctly.
      
      Reported by:	mmacy, others
      ad39591a
    • Ed Maste's avatar
      Avoid buffer underwrite in icmp_error · 2bfaf585
      Ed Maste authored
      icmp_error allocates either an mbuf (with pkthdr) or a cluster depending
      on the size of data to be quoted in the ICMP reply, but the calculation
      failed to account for the additional padding that m_align may apply.
      
      Include the ip header in the size passed to m_align.  On 64-bit archs
      this will have the net effect of moving everything 4 bytes later in the
      mbuf or cluster.  This will result in slightly pessimal alignment for
      the ICMP data copy.
      
      Also add an assertion that we do not move m_data before the beginning of
      the mbuf or cluster.
      
      Reported by:	A reddit user
      Reviewed by:	bz, jtl
      MFC after:	3 days
      Security:	CVE-2018-17156
      Sponsored by:	The FreeBSD Foundation
      Differential Revision:	https://reviews.freebsd.org/D17909
      2bfaf585
    • Eric van Gyzen's avatar
      in6_ifattach_linklocal: handle immediate removal of the new LLA · 68b84087
      Eric van Gyzen authored
      If another thread immediately removes the link-local address
      added by in6_update_ifa(), in6ifa_ifpforlinklocal() can return NULL,
      so the following assertion (or dereference) is wrong.
      Remove the assertion, and handle NULL somewhat better than panicking.
      This matches all of the other callers of in6_update_ifa().
      
      PR:		219250
      Reviewed by:	bz, dab (both an earlier version)
      MFC after:	1 week
      Sponsored by:	Dell EMC Isilon
      Differential Revision:	https://reviews.freebsd.org/D17898
      68b84087
    • Eric Joyner's avatar
      ixl/iavf(4): Fix TSO offloads when TXCSUM is disabled · 37761e2e
      Eric Joyner authored
      From Jake:
      The iflib stack does not disable TSO automatically when TXCSUM is
      disabled, instead assuming that the driver will correctly handle TSOs
      even when CSUM_IP is not set.
      
      This results in iflib calling ixl_isc_txd_encap with packets which have
      CSUM_IP_TSO, but do not have CSUM_IP or CSUM_IP_TCP set. Because of
      this, ixl_tx_setup_offload will not setup the IPv4 checksum offloading.
      
      This results in bad TSO packets being sent if a user disables TXCSUM
      without disabling TSO.
      
      Fix this by updating the ixl_tx_setup_offload function to check both
      CSUM_IP and CSUM_IP_TSO when deciding whether to enable IPv4 checksums.
      
      Once this is corrected, another issue for TSO packets is revealed. The
      driver sets IFLIB_NEED_ZERO_CSUM in order to enable a work around that
      causes the ip->sum field to be zero'd. This is necessary for ixl
      hardware to correctly perform TSOs.
      
      However, if TXCSUM is disabled, then the work around is not enabled, as
      CSUM_IP will not be set when the iflib stack checks to see if it should
      clear the sum field.
      
      Fix this by adding IFLIB_TSO_INIT_IP to the iflib flags for the iavf and
      ixl interface files.
      
      It is uncertain if the hardware needs IFLIB_NEED_ZERO_CSUM for any other
      case besides TSO, so leave that flag assigned. It may be worth
      investigating to see if this work around flag could be disabled in
      a future change.
      
      Once both of these changes are made, the ixl driver should correctly
      offload TSO packets when TSO4 offload is enabled, regardless of whether
      TXCSUM is enabled or disabled.
      
      Submitted by:	Jacob Keller <jacob.e.keller@intel.com>
      Reviewed by:	erj@, shurd@
      MFC after:	0 days
      Sponsored by:	Intel Corporation
      Differential Revision:	https://reviews.freebsd.org/D17900
      37761e2e
    • Mark Johnston's avatar
      Use --work-tree instead of specifying an absolute path. · 5186028d
      Mark Johnston authored
      Otherwise the diff command being run from outside the checkout resulted
      in warnings.
      
      Discussed with:	emaste
      X-MFC with:	r340083
      5186028d
    • Hans Petter Selasky's avatar
      Put a size limit on the opensm.log and use bzip2(1). · ba2c34f4
      Hans Petter Selasky authored
      Discussed with:		markj@
      Sponsored by:		Mellanox Technologies
      ba2c34f4
    • Hans Petter Selasky's avatar
      Revert r340246. · fa895a74
      Hans Petter Selasky authored
      Sponsored by:		Mellanox Technologies
      fa895a74
    • Mateusz Guzik's avatar
      amd64: align memset buffers to 16 bytes before using rep stos · f1161465
      Mateusz Guzik authored
      Both Intel manual and Agner Fog's docs suggest aligning to 16.
      
      See the review for benchmark results.
      
      Reviewed by:	kib (previous version)
      Sponsored by:	The FreeBSD Foundation
      Differential Revision:	https://reviews.freebsd.org/D17661
      f1161465
    • Bjoern A. Zeeb's avatar
      Update rum(4) and run(4) man pages to reflect that newer versions · 35359193
      Bjoern A. Zeeb authored
      of TP-LINK TL-WN321G are run(4) and not rum(4) anymore.
      
      Reported by:	J (tech-lists zyxst.net)
      MFC after:	3 days
      35359193
    • Eugene Grosbein's avatar
      ipfw.8: fix small syntax error in an example · 6ff080c4
      Eugene Grosbein authored
      MFC after:	3 days
      6ff080c4
    • Hans Petter Selasky's avatar
      Don't read the USB audio sync endpoint when we don't use it to save · fb8a716d
      Hans Petter Selasky authored
      isochronous bandwidth.
      
      MFC after:		3 days
      Sponsored by:		Mellanox Technologies
      fb8a716d