GitLab

* freebsd/current/main: (23 commits)
  tcp_hostcache: make THC_LOCK/UNLOCK macros to work with hash head pointer. Not a functional change.
  tcp_hostcache: style(9)
  tcp_hostcache: remove extraneous check. All paths leading here already checked this setting.
  tcp_hostcache: implement tcp_hc_updatemtu() via tcp_hc_update. Locking changes are planned here, and without this change too much copy-and-paste would be between these two functions.
  rtld: use _get_tp() in __tls_get_addr()
  rtld: avoid recursing on rtld_bind_lock for write
  rtld: allow to use tls_get_addr_slow() from context where rtld_bind_lock is locked
  rtld: style tls_get_addr_slow
  libc dl_iterate_phdr(): dlpi_tls_data is wrong
  libc: implement __tls_get_addr() for static binaries
  libc: add _get_tp() private function
  rtld: define TLS_DTV_OFFSET on all architectures
  libc: include rtld.h into static implementations of rtld interface
  libc: constify dummy error message string for dlfcn
  rtld_lock.h: Expand scope for IN_RTLD to avoid some conflicts with libc
  rtld/x86/reloc.c: style
  rtld_lock.h: remove tautological extern's
  Stop arming kqueue timers on knote owner suspend or terminate
  Add helper for kqueue timers callout scheduling
  Stop arming realtime posix process timers on suspend or terminate
  ...

This reverts commit 035aa578. The author
of the buggy commit has supposedly fixed it upstream. Revert this
reversion in preparation for the upstream changes.
Signed-off-by: Shawn Webb <shawn.webb@hardenedbsd.org>

Not a functional change.

Reviewed by:	rscheff

All paths leading here already checked this setting.

Reviewed by:	rscheff

Locking changes are planned here, and without this change too
much copy-and-paste would be between these two functions.

Reviewed by:	rscheff

This eliminates some non-trivial amount of code duplication, where done.
Only x86 and mips are handled right now.

Tested by:      bdragon (powerpc), mhorne (riscv)
Sponsored by:	The FreeBSD Foundation
MFC after:	1 week
Differential revision:	https://reviews.freebsd.org/D29623

This fixes a regression in d36d6816, where the call to
__tls_get_address() was performed under rtld_bind_lock write-locked.
Instead use tls_get_addr_slow() directly, with locked = true.

Reported by:	jkim, many others
Tested by:	jkim, bdragon (powerpc), mhorne (riscv)
Sponsored by:	The FreeBSD Foundation
MFC after:	1 week
Differential revision:	https://reviews.freebsd.org/D29623

Explicit locked parameter is added

Sponsored by:	The FreeBSD Foundation
MFC after:	1 week
Differential revision:	https://reviews.freebsd.org/D29623

Sponsored by:	The FreeBSD Foundation
MFC after:	1 week
Differential revision:	https://reviews.freebsd.org/D29623

This is the same change as d36d6816, but for libc static implementaion
of dl_iterate_phdr().

Reported by:	emacsray@gmail.com
PR:	254774
Sponsored by:	The FreeBSD Foundation
MFC after:	1 week
Differential revision:	https://reviews.freebsd.org/D29623

Sponsored by:	The FreeBSD Foundation
MFC after:	1 week
Differential revision:	https://reviews.freebsd.org/D29623

which returns pointer to tcb

Sponsored by:	The FreeBSD Foundation
MFC after:	1 week
Differential revision:	https://reviews.freebsd.org/D29623

Sponsored by:	The FreeBSD Foundation
MFC after:	1 week
Differential revision:	https://reviews.freebsd.org/D29623

and resolve naming conficts

Sponsored by:	The FreeBSD Foundation
MFC after:	1 week
Differential revision:	https://reviews.freebsd.org/D29623

Sponsored by:	The FreeBSD Foundation
MFC after:	1 week
Differential revision:	https://reviews.freebsd.org/D29623

Sponsored by:	The FreeBSD Foundation
MFC after:	1 week
Differential revision:	https://reviews.freebsd.org/D29623

Sponsored by:	The FreeBSD Foundation
MFC after:	1 week
Differential revision:	https://reviews.freebsd.org/D29623

Sponsored by:	The FreeBSD Foundation
MFC after:	1 week
Differential revision:	https://reviews.freebsd.org/D29623

This way, even if the process specified very tight reschedule
intervals, it should be stoppable/killable.

Reported and reviewed by:	markj
Tested by:	markj, pho
Sponsored by:	The FreeBSD Foundation
MFC after:	2 weeks
Differential revision:	https://reviews.freebsd.org/D29106

Reviewed by:	markj
Tested by:	markj, pho
Sponsored by:	The FreeBSD Foundation
MFC after:	2 weeks
Differential revision:	https://reviews.freebsd.org/D29106

Reported and reviewed by:	markj
Tested by:	markj, pho
Sponsored by:	The FreeBSD Foundation
MFC after:	2 weeks
Differential revision:	https://reviews.freebsd.org/D29106

Reported and reviewed by:	markj
Tested by:	markj, pho
Sponsored by:	The FreeBSD Foundation
MFC after:	2 weeks
Differential revision:	https://reviews.freebsd.org/D29106

The intent is to better handle time intervals with large amount of RIB
updates (e.g. BGP peer going up or down), while still keeping low sync
delay for the rest scenarios.

The implementation is the following: updates are bucketed into the
buckets of size 50ms. If the number of updates within a current bucket
 exceeds the threshold of 500 routes/sec (e.g. 10 updates per bucket
interval), the update is delayed for another 50ms. This can be repeated
 until the maximum update delay (1 sec) is reached.

All 3 variables are runtime tunables:

* net.route.algo.fib_max_sync_delay_ms: 1000
* net.route.algo.bucket_change_threshold_rate: 500
* net.route.algo.bucket_time_ms: 50

Differential Review:	https://reviews.freebsd.org/D29588
MFC after:		2 weeks

Reported by:	bdragon

* freebsd/current/main:
  sysctl.conf(5): Mention sysctl.conf.local in the sysctl.conf(5) manual page
  Removed the reference to the deprecated splx API from ifnet(9).

The possibility of using a sysctl.conf.local on a machine that has a shared
sysctl.conf(5) isn't documented. So mention the sysctl.conf.local in the
manual page.

PR:	254901
Submitted by:	Jose Luis Duran <jlduran at gmail dot com>
Reported by:	Jose Luis Duran <jlduran at gmail dot com>
Reviewed by:	markj
MFC after:	3 days
Differential Revision:	https://reviews.freebsd.org/D29673

Reviewed by:		emaste, markj
PR:			254880
MFC After:		1 week
Differential Revision:	https://reviews.freebsd.org/D29666

* freebsd/current/main:
  lpd(8): Mention the author of a paper in the SEE ALSO section
  config(8): Mention the authors of a paper in the SEE ALSO section
  ed(1): Add two references in the SEE ALSO section
  pci_dw: Trim ATU windows bigger than 4GB

Obtained from:	OpenBSD
MFC after:	1 week

Obtained from:	OpenBSD
MFC after:	1 week

Obtained from:	OpenBSD
MFC after:	1 week

The size of the ATU MEM/IO windows is implicitly casted to uint32_t.
Because of that some window sizes were silently demoted to 0 and ignored.
Check the size if its too large, trim it to 4GB and print a warning message.

Submitted by: Kornel Duleba <mindal@semihalf.com>
Reviewed by: mw
Obtained from: Semihalf
Sponsored by: Marvell
Differential revision: https://reviews.freebsd.org/D29625

* freebsd/current/main:
  UPDATING: dereference portupgrade(8)
  struct mount uppers: correct locking annotations

Make the UPDATING file less tool-specific regarding upgrading
third-party software.

MFC after:	3 weeks
Sponsored by:	Rubicon Communications, LLC ("Netgate")

It is all locked by the uppers' interlock.

Noted by:	Alexander Lochmann <alexander.lochmann@tu-dortmund.de>
Sponsored by:	The FreeBSD Foundation
MFC after:	3 days

* freebsd/current/main:
  nfsd: fix replies from session cache for retried RPCs
  Enforce check for using the return result for ifa?_try_ref().
  m4(1): Add a SEE ALSO section and reference an AT&T manual
  sed(1): Add a reference for a 4.4BSD manual document
  tcp: Use jenkins_hash32() in hostcache
  tcp_hostcache.c: remove unneeded includes.
  tcp_hostcache: add bool argument for tcp_hc_lookup() to tell are we looking to only read from the result, or to update it as well. For now doesn't affect locking, but allows to push stats and expire update into single place.
  tcp_hostcache: hide rmx_hits/rmx_updates under ifdef.
  Remove tcp_hostcache.h.  Everything is private.
  tcp: Prepare PRR to work with NewReno LossRecovery
  Avoid -pedantic warnings about using _Generic in __fp_type_select

Recent testing of network partitioning a FreeBSD NFSv4.1
server from a Linux NFSv4.1 client identified problems
with both the FreeBSD server and Linux client.

The FreeBSD server failec to reply using the cached
reply in the session slot when an RPC was retried on
the session slot, as indicated by same slot sequence#.

This patch fixes this.  It should also fix a similar
failure for NFSv4.0 mounts, when the sequence# in
the open/lock_owner requires a reply be done from
an entry locked into the DRC.

This fix affects the fairly rare case where a NFSv4
client retries a non-idempotent RPC, such as a lock
operation.  Note that retries only occur after the
client has needed to create a new TCP connection.

MFC after:	2 weeks

* freebsd/current/main:
  bhyve: fix regression in legacy virtio-9p config parsing
  [tcp] Fix ECN on finalizing sessions.
  Clean up the style in the arm64 bus.h
  arm64: clear debug register state on fork
  pf: Remove unused variable rt_listid from struct pf_krule
  vfs: replace vfs_smr_quiesce with vfs_smr_synchronize
  Remove the last users of ARM_TP_ADDRESS
  arm64: Fix finding the pmc event ID
  Discard the arm64 VFP state before resetting it

Commit 621b5090 introduced a regression
in legacy virtio-9p config parsing by not initializing *sharename to
NULL. As a result, "sharename != NULL" check in the first iteration fails
and bhyve exits with "virtio-9p: more than one share name given".

Fix by adding NULL back.

Approved by:	grehan