Move: devel/libdouble-conversion -> devel/double-conversion

While in devel/double-conversion, order USExx clauses, and replace CMAKE_POSITION_INDEPENDENT_CODE with BUILD_SHARED_LIBS since shared libs should be a default

Update and bump databases/clickhouse

Approved by:	portmgr blanket

MOVED

@@ -11622,3 +11622,4 @@ net-p2p/verlihub-plugins-luascript||2019-02-16|Has expired: Verlihub uses legacy
 net-p2p/verlihub-plugins-messanger||2019-02-16|Has expired: Verlihub uses legacy GeoIP 1 format which no longer works; switch to GeoIP 2 where possible
 net-p2p/verlihub-plugins-stats||2019-02-16|Has expired: Verlihub uses legacy GeoIP 1 format which no longer works; switch to GeoIP 2 where possible
 www/mod_geoip2|www/mod_maxminddb|2019-02-16|Has expired: Uses legacy GeoIP 1 format which no longer works; switch to GeoIP 2 where possible
+devel/libdouble-conversion|devel/double-conversion|2019-02-16|Rename to match the project name on github and on most other systems, and in installed cmake files

databases/clickhouse/Makefile

@@ -5,7 +5,7 @@ PORTNAME=	clickhouse
 PORTVERSION=	18.14.18
 DISTVERSIONPREFIX=	v
 DISTVERSIONSUFFIX=	-stable
-PORTREVISION=	2
+PORTREVISION=	3
 CATEGORIES=	databases
 
 MAINTAINER=	proler@gmail.com
@@ -18,9 +18,9 @@ ONLY_FOR_ARCHS_REASON=	"Only supported on amd64"
 
 BUILD_DEPENDS=	bash:shells/bash \
 		sparsehash>=0:devel/sparsehash \
-		cctz>=0:devel/cctz \
-		libdouble-conversion>=0:devel/libdouble-conversion
-LIB_DEPENDS=	libtcmalloc.so:devel/google-perftools \
+		cctz>=0:devel/cctz
+LIB_DEPENDS=	libdouble-conversion.so:devel/double-conversion \
+		libtcmalloc.so:devel/google-perftools \
 		libodbc.so:databases/unixODBC \
 		libltdl.so:devel/libltdl \
 		libicudata.so:devel/icu \

devel/Makefile

@@ -478,6 +478,7 @@
     SUBDIR += doctorj
     SUBDIR += dolphin-plugins
     SUBDIR += dotconf
+    SUBDIR += double-conversion
     SUBDIR += doxygen
     SUBDIR += dparser
     SUBDIR += dprog
@@ -1414,7 +1415,6 @@
     SUBDIR += libdlna
     SUBDIR += libdnsres
     SUBDIR += libdombey
-    SUBDIR += libdouble-conversion
     SUBDIR += libdparse
     SUBDIR += libds
     SUBDIR += libdsp

devel/libdouble-conversion/Makefile → devel/double-conversion/Makefile

 # Created by: Waitman Gobble <waitman@waitman.net>
 # $FreeBSD$
 
-PORTNAME=	libdouble-conversion
+PORTNAME=	double-conversion
 PORTVERSION=	3.0.0
 DISTVERSIONPREFIX=	v
 CATEGORIES=	devel
@@ -15,11 +15,10 @@ LICENSE_FILE=	${WRKSRC}/LICENSE
 #BROKEN_aarch64=	Fails to build: Target architecture was not detected as supported by Double-Conversion
 
 USES=		cmake
-USE_LDCONFIG=	yes
-CMAKE_ARGS=	-DCMAKE_POSITION_INDEPENDENT_CODE=1
-
 USE_GITHUB=	yes
 GH_ACCOUNT=	google
-GH_PROJECT=	double-conversion
+USE_LDCONFIG=	yes
+
+CMAKE_ON=	BUILD_SHARED_LIBS
 
 .include <bsd.port.mk>

devel/libdouble-conversion/pkg-plist → devel/double-conversion/pkg-plist

@@ -11,4 +11,6 @@ lib/cmake/double-conversion/double-conversionConfig.cmake
 lib/cmake/double-conversion/double-conversionConfigVersion.cmake
 lib/cmake/double-conversion/double-conversionLibraryDepends-%%CMAKE_BUILD_TYPE%%.cmake
 lib/cmake/double-conversion/double-conversionLibraryDepends.cmake
-lib/libdouble-conversion.a
+lib/libdouble-conversion.so
+lib/libdouble-conversion.so.1
+lib/libdouble-conversion.so.1.0.0