Commit 628190fa authored by mva's avatar mva
Browse files

Convert the Python framework bits to USES=python.

Please use USES=python instead of USE_PYTHON.

  USE_PYTHON=yes becomes USES=python
  USE_PYTHON=2.7+ becomes USES=python:2.7+
  USE_PYTHON_BUILD=3.3 becomes USES=python:3.3,build
  ...

A new PYTHON_FEATURES variable was added, which enables certain features for a
port and replaces some knobs at the same time;

  PYTHON_FEATURES=distutils replaces USE_PYDISTUTILS
  PYTHON_FEATURES=autoplist replaces PYDISTUTILS_AUTOPLIST
  PYTHON_FEATURES=py3kplist replaces PYTHON_PY3K_PLIST_HACK
  PYTHON_FEATURES=noegginfo replaces PYDISTUTILS_NOEGGINFO
  PYTHON_FEATURES=concurrent replaces PYTHON_CONCURRENT_INSTALL
  PYTHON_FEATURES=pythonprefix replaces USE_PYTHON_PREFIX

Some knobs have been deprecated and are to be removed in the near future:

  PYTHON_MASTER_SITES - use MASTER_SITE_PYTHON instead
  PYTHON_PKGNAMESUFFIX - use PYTHON_PKGNAMEPREFIX instead
  PYDISTUTILS_INSTALLNOSINGLE - deprecated without replacement

Some knobs have been removed completely:

  PYTHON_MASTER_SITE_SUBDIR
  PYTHON_DISTNAME
  PYTHON_WRKSRC

Several variables specific to the Python framework are no longer passed to the
build environment to avoid polluting dependency builds.

  PYTHON_VERSION is not passed to .MAKEFLAGS anymore
  PYTHON_DEFAULT_VERSION,
  PYTHON_DEFAULT_PORTVERSION and
  PYTHONBASE are not passed to the make environment anymore

The conversion required a couple of ports to be updated to fit the changes and
new requirements. Those included "bsd.python.mk" directly or contained checks
in places, for which the USES framework would fail to provide correct values.

Python modules directly using the upstream Python package (such as py-tkinter
or py-sqlite3) were updated to avoid using the now unnecessary and remmoved
knobs from "bsd.python.mk".

Phabric:	D399
exp-run:	167368 192357
PR:		167368 192357
Reviewed by:	antoine, wg
Exp-run award:	antoine
With hat:	python@
Approved by:	portmgr
parent d13f7a46
......@@ -10,6 +10,29 @@ in the release notes and/or placed into UPDATING.
All ports committers are allowed to commit to this file.
20140809:
AUTHOR: mva@FreeBSD.org
The Python language bits of the poorts framework have been converted
to USES. Instead of USE_PYTHON, please use USES=python instead.
USE_PYTHON=yes becomes USES=python
USE_PYTHON=2.7+ becomes USES=python:2.7+
USE_PYTHON_BUILD=3.3 becomes USES=python:3.3,build
...
Additionally, several Python specific feeatures have been converted
to USES-inspired PYTHON_FEATURES=<featureA>,<featureB>.
USE_PYDISTUTILS becomes PYTHON_FEATURES=distutils
PYDISTUTILS_AUTOPLIST becomes PYTHON_FEATURES=autoplist
...
Please read the header comments of Uses/python.mk for more details
about the new and changed bits and pieces. You will find a list of
deprecated variables and how to replace them in your own ports at
the end of the header comment.
20140715:
AUTHOR: bapt@FreeBSD.org
......
This diff is collapsed.
......@@ -394,10 +394,6 @@ FreeBSD_MAINTAINER= portmgr@FreeBSD.org
# USE_OCAML - If set, this port relies on the OCaml language.
# Implies inclusion of bsd.ocaml.mk. (Also see
# that file for more information on USE_OCAML*).
# USE_PYTHON - If set, this port relies on the Python language.
# Implies inclusion of bsd.python.mk. (Also see
# that file for more information on USE_PYTHON_*
# and USE_PYDISTUTILS).
# USE_RUBY - If set, this port relies on the Ruby language.
# Implies inclusion of bsd.ruby.mk. (Also see
# that file for more information on USE_RUBY_*).
......@@ -1444,7 +1440,7 @@ PKGCOMPATDIR?= ${LOCALBASE}/lib/compat/pkg
.endif
.if defined(USE_PYTHON) || defined(USE_PYTHON_BUILD) || defined(USE_PYTHON_RUN)
.include "${PORTSDIR}/Mk/bsd.python.mk"
USES+= python
.endif
.if defined(USE_EFL) || defined(WANT_EFL) || defined(USE_EFL_ESMART)
......@@ -1890,10 +1886,6 @@ IGNORE= Do not define STAGEDIR in command line
.include "${PORTSDIR}/Mk/bsd.php.mk"
.endif
.if defined(USE_PYTHON)
.include "${PORTSDIR}/Mk/bsd.python.mk"
.endif
.if defined(USE_WX) || defined(USE_WX_NOT)
.include "${PORTSDIR}/Mk/bsd.wx.mk"
.endif
......
......@@ -106,20 +106,6 @@ HAVE_COMPAT_IA32_KERN!= if ${SYSCTL} -n compat.ia32.maxvmem >/dev/null 2>&1; the
CONFIGURE_MAX_CMD_LEN!= ${SYSCTL} -n kern.argmax
.endif
.if !defined(PYTHON_DEFAULT_VERSION)
PYTHON_DEFAULT_VERSION!= ${MAKE} -V PYTHON_DEFAULT_VERSION USE_PYTHON=1 -f ${PORTSDIR}/Mk/bsd.port.mk
.endif
.if !defined(PYTHON_DEFAULT_PORTVERSION)
# We are caching the PYTHON_PORTVERSION of the default python version so we can reuse it in the
# common case.
PYTHON_DEFAULT_PORTVERSION!= ${MAKE} -V PYTHON_PORTVERSION USE_PYTHON=1 -f ${PORTSDIR}/Mk/bsd.port.mk
.endif
.if !defined(PYTHONBASE)
PYTHONBASE!= ${MAKE} -V PYTHONBASE USE_PYTHON=1 -f ${PORTSDIR}/Mk/bsd.port.mk
.endif
.if !defined(_JAVA_VERSION_LIST_REGEXP)
_JAVA_VERSION_LIST_REGEXP!= ${MAKE} -V _JAVA_VERSION_LIST_REGEXP USE_JAVA=1 -f ${PORTSDIR}/Mk/bsd.port.mk
.endif
......@@ -367,9 +353,6 @@ README.html:
UID="${UID:S/"/"'"'"/g:S/\$/\$\$/g:S/\\/\\\\/g}" \
HAVE_COMPAT_IA32_KERN="${HAVE_COMPAT_IA32_KERN}" \
CONFIGURE_MAX_CMD_LEN="${CONFIGURE_MAX_CMD_LEN}" \
PYTHON_DEFAULT_VERSION="${PYTHON_DEFAULT_VERSION}" \
PYTHON_DEFAULT_PORTVERSION="${PYTHON_DEFAULT_PORTVERSION}" \
PYTHONBASE="${PYTHONBASE}" \
_JAVA_VERSION_LIST_REGEXP="${_JAVA_VERSION_LIST_REGEXP:Q}" \
_JAVA_VENDOR_LIST_REGEXP="${_JAVA_VENDOR_LIST_REGEXP:Q}" \
_JAVA_OS_LIST_REGEXP="${_JAVA_OS_LIST_REGEXP:Q}" \
......
......@@ -118,11 +118,39 @@ DEV_WARNING+= "USE_AUTOTOOLS=libtool is deprecated, please use USES=libtool"
DEV_WARNING+= "USE_GNOME=ltverhack is deprecated, please use USES=libtool"
.endif
.if defined(USE_PYTHON)
.if ${USE_PYTHON} != "yes"
DEV_WARNING+= "USE_PYTHON is deprecated, please use USES=python:${USE_PYTHON}"
.else
DEV_WARNING+= "USE_PYTHON is deprecated, please use USES=python"
.endif
.endif
.if defined(USE_PYTHON_RUN)
.if ${USE_PYTHON_RUN} != "yes"
DEV_WARNING+= "USE_PYTHON_RUN is deprecated, please use USES=python:${USE_PYTHON_RUN},run"
.else
DEV_WARNING+= "USE_PYTHON_RUN is deprecated, please use USES=python:run"
.endif
.endif
.if defined(USE_PYTHON_BUILD)
.if ${USE_PYTHON_BUILD} != "yes"
DEV_WARNING+= "USE_PYTHON_BUILD is deprecated, please use USES=python:${USE_PYTHON_BUILD},build"
.else
DEV_WARNING+= "USE_PYTHON_BUILD is deprecated, please use USES=python:build"
.endif
.endif
.if defined(PYDISTUTILS_INSTALLNOSINGLE)
DEV_WARNING+= "PYDISTUTILS_INSTALLNOSINGLE is deprecated, please do not use it anymore"
.endif
SANITY_UNSUPPORTED= USE_OPENAL USE_FAM USE_MAKESELF USE_ZIP USE_LHA USE_CMAKE \
USE_READLINE USE_ICONV PERL_CONFIGURE PERL_MODBUILD \
USE_PERL5_BUILD USE_PERL5_RUN USE_DISPLAY USE_FUSE \
USE_GETTEXT USE_GMAKE USE_SCONS USE_DRUPAL
SANITY_DEPRECATED= USE_XZ USE_BZIP2
SANITY_DEPRECATED= USE_XZ USE_BZIP2 USE_PYDISTUTILS PYTHON_CONCURRENT_INSTALL \
PYDISTUTILS_AUTOPLIST PYTHON_PY3K_PLIST_HACK PYDISTUTILS_NOEGGINFO \
PYTHON_MASTER_SITES USE_PYTHON_PREFIX PYTHON_PKGNAMESUFFIX
USE_OPENAL_ALT= USES=openal
USE_FAM_ALT= USES=fam
......@@ -144,6 +172,14 @@ USE_FUSE_ALT= USES=fuse
USE_GETTEXT_ALT= USES=gettext
USE_SCONS_ALT= USES=scons
USE_DRUPAL_ALT= USES=drupal
USE_PYDISTUTILS_ALT= PYTHON_FEATURES=distutils
PYTHON_CONCURRENT_INSTALL_ALT= PYTHON_FEATURES=concurrent
PYDISTUTILS_AUTOPLIST_ALT= PYTHON_FEATURES=autoplist
PYTHON_PY3K_PLIST_HACK_ALT= PYTHON_FEATURES=py3kplist
PYDISTUTILS_NOEGGINFO_ALT= PYTHON_FEATURES=noegginfo
USE_PYTHON_PREFIX_ALT= PYTHON_FEATURES=pythonprefix
PYTHON_PKGNAMESUFFIX_ALT= PYTHON_PKGNAMEPREFIX
PYTHON_MASTER_SITES_ALT= MASTER_SITE_PYTHON
.for a in ${SANITY_DEPRECATED}
.if defined(${a})
......
......@@ -1501,7 +1501,6 @@ MASTER_SITES_SUBDIRS= APACHE_JAKARTA:${PORTNAME:S,-,/,}/source \
NETLIB:${PORTNAME} \
PERL_CPAN:${PORTNAME:C/-.*//} \
PNET:${PNET_MASTER_SITE_SUBDIR} \
PYTHON:${PYTHON_MASTER_SITE_SUBDIR} \
RUBY_DBI:${RUBY_DBI_MASTER_SITE_SUBDIR} \
RUBY_GNOME:${RUBY_GNOME_MASTER_SITE_SUBDIR} \
SAVANNAH:${PORTNAME:tl} \
......
......@@ -100,7 +100,6 @@ CONFIGURE_ARGS+= --disable-libnotify
.if exists(${LOCALBASE}/libdata/pkgconfig/gst-python-0.10.pc)
USE_PYTHON= yes
.include "${PORTSDIR}/Mk/bsd.python.mk"
USE_GSTREAMER+= python
CONFIGURE_ARGS+=--enable-python
PLIST_SUB+= PYTHON=""
......
......@@ -25,7 +25,7 @@ WRKSRC= ${WRKDIR}/${PORTNAME}-${PORTVERSION}
.include <bsd.port.options.mk>
.if ${PORT_OPTIONS:MPYTHON}
.include "../../Mk/bsd.python.mk"
USE_PYTHON= yes
BUILD_DEPENDS+= ${LOCALBASE}/bin/python:${PORTSDIR}/lang/python
CONFIGURE_ARGS+= --with-python
PLIST_SUB+= WITH_PYTHON="" \
......@@ -35,7 +35,7 @@ PLIST_SUB+= WITH_PYTHON="@comment "
.endif
.if ${PORT_OPTIONS:MRUBY}
.include "../../Mk/bsd.ruby.mk"
USE_RUBY= yes
BUILD_DEPENDS+= ${LOCALBASE}/bin/ruby:${PORTSDIR}/lang/ruby19
CONFIGURE_ARGS+= --with-ruby
PLIST_SUB+= WITH_RUBY=""
......
......@@ -16,7 +16,7 @@ LICENSE= GPLv3
CONFLICTS= *samba3[0-4]-3.*
USES= compiler pkgconfig
USE_PYTHON_BUILD= 2
USE_PYTHON= 2
USE_LDCONFIG= yes
WAF_TOOL= buildtools/bin/waf
CONFIGURE_LOG= bin/config.log
......@@ -97,15 +97,11 @@ CONFIGURE_ARGS+= --jobs=${MAKE_JOBS_NUMBER}
_MAKE_JOBS+= --jobs=${MAKE_JOBS_NUMBER}
.endif
USE_PYTHON_RUN= yes
PLIST_FILES+= include/pyldb.h \
lib/libpyldb-util.so \
lib/libpyldb-util.so.1 \
%%PYTHON_SITELIBDIR%%/ldb.so \
%%PKGCONFIGDIR%%/pyldb-util.pc
PLIST_DIRSTRY+= %%PYTHON_SITELIBDIR%% \
%%PYTHON_LIBDIR%%
LDB_MAN1= man/man1/ldbadd.1.gz \
man/man1/ldbdel.1.gz \
......
......@@ -25,7 +25,6 @@ OPTIONS_DEFAULT= PYTHON
.if ${PORT_OPTIONS:MPYTHON}
USE_PYTHON= yes
.include "${PORTSDIR}/Mk/bsd.python.mk"
CONFIGURE_ARGS+= --with-python=${LOCALBASE}
CATEGORIES+= python
PLIST_SUB+= WITH_PYTHON=""
......
......@@ -36,6 +36,13 @@ MANPAGES_DESC= Build and install manpages (requires textproc/docbook-xsl)
.include <bsd.port.options.mk>
.if defined(NO_PYTHON)
CONFIGURE_ARGS+= --disable-python
.else
USE_PYTHON_RUN= yes
PLIST_FILES+= %%PYTHON_SITELIBDIR%%/ntdb.so
.endif
.include <bsd.port.pre.mk>
.if ! ${PORT_OPTIONS:MMANPAGES}
......@@ -45,7 +52,7 @@ BUILD_DEPENDS+= ${LOCALBASE}/share/xsl/docbook/manpages/docbook.xsl:${PORTSDIR}
xsltproc:${PORTSDIR}/textproc/libxslt
.endif
PLIST_FILES= bin/ntdbbackup \
PLIST_FILES+= bin/ntdbbackup \
bin/ntdbdump \
bin/ntdbrestore \
bin/ntdbtool \
......@@ -66,15 +73,6 @@ CONFIGURE_ARGS+= --jobs=${MAKE_JOBS_NUMBER}
_MAKE_JOBS+= --jobs=${MAKE_JOBS_NUMBER}
.endif
.if defined(NO_PYTHON)
CONFIGURE_ARGS+= --disable-python
.else
USE_PYTHON_RUN= yes
PLIST_FILES+= %%PYTHON_SITELIBDIR%%/ntdb.so
PLIST_DIRSTRY+= %%PYTHON_SITELIBDIR%% \
%%PYTHON_LIBDIR%%
.endif
TDB_MAN3= man/man3/ntdb.3.gz
TDB_MAN8= man/man8/ntdbbackup.8.gz \
......
......@@ -6,9 +6,9 @@ PORTVERSION= ${PYTHON_PORTVERSION}
PORTREVISION= 4
CATEGORIES= databases python
MASTER_SITES= PYTHON
MASTER_SITE_SUBDIR= ${PYTHON_MASTER_SITE_SUBDIR}
MASTER_SITE_SUBDIR= ftp/python/${PORTVERSION}
PKGNAMEPREFIX= ${PYTHON_PKGNAMEPREFIX}
DISTNAME= ${PYTHON_DISTNAME}
DISTNAME= Python-${PORTVERSION}
MAINTAINER= python@FreeBSD.org
COMMENT= Standard Python bindings to the Berkeley DB library
......@@ -24,7 +24,7 @@ USES= tar:xz
DIST_SUBDIR= python
DISTINFO_FILE= ${PORTSDIR}/lang/python${PYTHON_SUFFIX}/distinfo
WRKSRC= ${PYTHON_WRKSRC}/Modules
WRKSRC= ${WRKDIR}/Python-${PORTVERSION}/Modules
PYDISTUTILS_INSTALLARGS+= --install-lib ${PYTHON_LIBDIR}/lib-dynload
PYDISTUTILS_AUTOPLIST= yes
......
......@@ -5,10 +5,10 @@ PORTNAME= gdbm
PORTVERSION= ${PYTHON_PORTVERSION}
PORTREVISION= 3
CATEGORIES= databases python
MASTER_SITES= ${PYTHON_MASTER_SITES}
MASTER_SITE_SUBDIR= ${PYTHON_MASTER_SITE_SUBDIR}
MASTER_SITES= PYTHON
MASTER_SITE_SUBDIR= ftp/python/${PORTVERSION}
PKGNAMEPREFIX= ${PYTHON_PKGNAMEPREFIX}
DISTNAME= ${PYTHON_DISTNAME}
DISTNAME= Python-${PORTVERSION}
MAINTAINER= python@FreeBSD.org
COMMENT= Python bindings to the GNU dbm library
......@@ -28,7 +28,7 @@ PYDISTUTILS_INSTALLARGS+= --install-lib ${PYTHONPREFIX_LIBDIR}/lib-dynload
DIST_SUBDIR= python
DISTINFO_FILE= ${PORTSDIR}/lang/python${PYTHON_SUFFIX}/distinfo
WRKSRC= ${PYTHON_WRKSRC}/Modules
WRKSRC= ${WRKDIR}/Python-${PORTVERSION}/Modules
.include <bsd.port.pre.mk>
......
......@@ -5,10 +5,10 @@ PORTNAME= sqlite3
PORTVERSION= ${PYTHON_PORTVERSION}
PORTREVISION= 5
CATEGORIES= databases python
MASTER_SITES= ${PYTHON_MASTER_SITES}
MASTER_SITE_SUBDIR= ${PYTHON_MASTER_SITE_SUBDIR}
MASTER_SITES= PYTHON
MASTER_SITE_SUBDIR= ftp/python/${PORTVERSION}
PKGNAMEPREFIX= ${PYTHON_PKGNAMEPREFIX}
DISTNAME= ${PYTHON_DISTNAME}
DISTNAME= Python-${PORTVERSION}
MAINTAINER= python@FreeBSD.org
COMMENT= Standard Python binding to the SQLite3 library
......@@ -25,7 +25,7 @@ USES= tar:xz
DIST_SUBDIR= python
DISTINFO_FILE= ${PORTSDIR}/lang/python${PYTHON_SUFFIX}/distinfo
WRKSRC= ${PYTHON_WRKSRC}/Modules
WRKSRC= ${WRKDIR}/Python-${PORTVERSION}/Modules
PYDISTUTILS_INSTALLARGS+= --install-lib ${PYTHON_LIBDIR}/lib-dynload
PYDISTUTILS_AUTOPLIST= yes
......
......@@ -43,7 +43,6 @@ RUBY_MODULE_DESC= Build RUBY bindings
USE_PYTHON= yes
INSTALLS_EGGINFO=yes
PYDISTUTILS_EGGINFO=py_rrdtool-0.2.2-${PYTHON_VERSION:S/thon//}.egg-info
.include "${PORTSDIR}/Mk/bsd.python.mk"
PLIST_SUB+= WITH_PYTHON=""
CONFIGURE_ARGS+= --enable-python
.else
......
......@@ -32,7 +32,6 @@ OPTIONS_DEFAULT= PERL
USE_PYTHON= yes
INSTALLS_EGGINFO=yes
PYDISTUTILS_EGGINFO=py_rrdtool-0.2.1-${PYTHON_VERSION:S/thon//}.egg-info
.include "${PORTSDIR}/Mk/bsd.python.mk"
PLIST_SUB+= WITH_PYTHON=""
CONFIGURE_ARGS+= --enable-python
.else
......@@ -42,7 +41,6 @@ PLIST_SUB+= WITH_PYTHON="@comment "
.if ${PORT_OPTIONS:MRUBY}
USE_RUBY= yes
.include "${PORTSDIR}/Mk/bsd.ruby.mk"
PLIST_SUB+= WITH_RUBY=""
CONFIGURE_ARGS+= --enable-ruby
.else
......
......@@ -35,6 +35,17 @@ MANPAGES_DESC= Build and install manpages (requires textproc/docbook-xsl)
.include <bsd.port.options.mk>
.if defined(NO_PYTHON)
CONFIGURE_ARGS+= --disable-python
.else
USE_PYTHON_RUN= yes
PLIST_FILES+= %%PYTHON_SITELIBDIR%%/tdb.so
.endif
.if defined(NO_PYTHON)
.endif
.include <bsd.port.pre.mk>
.if ! ${PORT_OPTIONS:MMANPAGES}
......@@ -44,7 +55,7 @@ BUILD_DEPENDS+= ${LOCALBASE}/share/xsl/docbook/manpages/docbook.xsl:${PORTSDIR}
xsltproc:${PORTSDIR}/textproc/libxslt
.endif
PLIST_FILES= bin/tdbbackup \
PLIST_FILES+= bin/tdbbackup \
bin/tdbdump \
bin/tdbrestore \
bin/tdbtool \
......@@ -65,15 +76,6 @@ CONFIGURE_ARGS+= --jobs=${MAKE_JOBS_NUMBER}
_MAKE_JOBS+= --jobs=${MAKE_JOBS_NUMBER}
.endif
.if defined(NO_PYTHON)
CONFIGURE_ARGS+= --disable-python
.else
USE_PYTHON_RUN= yes
PLIST_FILES+= %%PYTHON_SITELIBDIR%%/tdb.so
PLIST_DIRSTRY+= %%PYTHON_SITELIBDIR%% \
%%PYTHON_LIBDIR%%
.endif
TDB_MAN8= man/man8/tdbbackup.8.gz \
man/man8/tdbdump.8.gz \
man/man8/tdbrestore.8.gz \
......
......@@ -15,10 +15,10 @@ LICENSE= MIT
OPTIONS_DEFINE= DOCS
USES= uniquefiles
USE_PYTHON= yes
USE_PYDISTUTILS= yes
PYDISTUTILS_AUTOPLIST= yes
PYTHON_CONCURRENT_INSTALL= yes
PORTDOCS= README.rst \
CHANGES.rst
......
......@@ -68,7 +68,7 @@ lib/libpyglib-gi-2.0-%%PYTHON_VERSION%%.so.0.0.0
%%PYTHON_SITELIBDIR%%/gi/types.py
%%PYTHON_SITELIBDIR%%/gi/types.pyc
%%PYTHON_SITELIBDIR%%/gi/types.pyo
%%PYTHON_SITELIBDIR%%/pygobject-%%VERSION%%-py%%PYTHON_VERSION%%-%%OPSYS%%-%%UNAME_R%%-%%ARCH%%.egg-info
%%PYTHON_SITELIBDIR%%/pygobject-%%VERSION%%-py%%PYTHON_VER%%-%%OPSYS%%-%%UNAME_R%%-%%ARCH%%.egg-info
%%PYTHON_SITELIBDIR%%/pygtkcompat/__init__.py
%%PYTHON_SITELIBDIR%%/pygtkcompat/__init__.pyc
%%PYTHON_SITELIBDIR%%/pygtkcompat/__init__.pyo
......
......@@ -29,7 +29,7 @@ CONFLICTS= py*-gtk-0* py*-gobject-2.*.[0-6] py*-gobject-2.*.[7-9] \
py*-gobject-2.*.6_1
PLIST_SUB= ARCH=${ARCH} UNAME_R=${UNAME_R} VERSION=${PORTVERSION} \
OPSYS=${OPSYS:tl}
OPSYS=${OPSYS:tl} PYTHON_VER=${PYTHON_VER}
.if ${SLAVE_PORT} == no
BUILD_DEPENDS+= ${LOCALBASE}/libdata/pkgconfig/pycairo.pc:${PORTSDIR}/graphics/py-cairo
......
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment