GitLab

It it useful to run pkg.exec for example

while here: update manpage after the removal of @*exec

@*exec will now on be directly implemented in the ports tree

for historical reason +DISPLAY was parsed first to ensure it takes
precedence over any message in the +MANIFEST to avoid the message
to be overriden later.

Since the messages has been switch to ucl files, all messages are
appended so there is no needed anymore for this backward compat.

Moreover it was preventing the variable expansions to happen because
the pkg structure was not yet defined

When processing the right side of a two compare the sign could be
improperly set to the left side sign varible when using <= >= or ==.

Clang11 supports the flag.

Needs to be part of the same shell command

This should help find uninitialized variables. Not enabled on FreeBSD
yet since I'm not sure if the FreeBSD11 Clang is new enough.

There are some additional UBSan warnings with newer Clang that need to be
fixed first.

If p->prefix is empty, we end up using -1 as the index.

First argument to memset should be non-null.

Can't shift a uint8_t by 24.

It appears there is a real or false-positive memory leak in vasprintf
in glibc.

Direct leak of 3456 byte(s) in 1 object(s) allocated from:
    #0 0x7fb5ed3bf748 in __interceptor_realloc (/lib64/libasan.so.6+0xab748)
    #1 0x78992c in ucl_utstring_append_len src/ucl_emitter_utils.c:239
    #2 0x784247 in ucl_emitter_finish_object src/ucl_emitter.c:174
    #3 0x785ba1 in ucl_emitter_common_elt src/ucl_emitter.c:423
    #4 0x784f41 in ucl_emitter_common_start_object src/ucl_emitter.c:323
    #5 0x785f6b in ucl_emitter_common_elt src/ucl_emitter.c:449
    #6 0x786572 in ucl_emit_config_elt src/ucl_emitter.c:511
    #7 0x7872cb in ucl_object_emit_full src/ucl_emitter.c:681
    #8 0x786fdb in ucl_object_emit_len src/ucl_emitter.c:652
    #9 0x786ebf in ucl_object_emit src/ucl_emitter.c:633
    #10 0x5bf370 in pkg_object_dump /pkg/libpkg/pkg_object.c:38
    #11 0x5c8022 in pkg_config_dump /pkg/libpkg/pkg_config.c:560
    #12 0x43deb8 in show_version_info /pkg/src/main.c:387
    #13 0x43f614 in main /pkg/src/main.c:809
    #14 0x7fb5ec8a31e1 in __libc_start_main (/lib64/libc.so.6+0x281e1)

Direct leak of 6 byte(s) in 1 object(s) allocated from:
    #0 0x7f85d208f547 in strdup (/lib64/libasan.so.6+0x58547)
    #1 0x497b37 in xstrdup /pkg/libpkg/xmalloc.h:34
    #2 0x497b37 in elf_note_analyse /pkg/libpkg/pkg_elf.c:780
    #3 0x497b37 in pkg_get_myarch_elfparse /pkg/libpkg/pkg_elf.c:907