Skip to content
  • tijl's avatar
    Remove iconv(), iconv_open() and iconv_close() symbols from libiconv. · 922a618b
    tijl authored
    These were FreeBSD specific aliases for libiconv(), libiconv_open() and
    libiconv_close() that are now also provided by libc which complicates
    writing configure tests that work correctly when both libc iconv and
    libiconv are available.
    
    Also, because the libiconv iconv.h header redefines iconv* to libiconv*
    correct use of the header implies that the aliases aren't used.
    
    The following ports needed fixes because there was something wrong with
    the way they tried to detect or use iconv:
    
    audio/deadbeef: Remove LIBICONV_PLUG from a source file.  It's a
    compile-time option and should not be set in source code.
    comms/hidapi: Use standard AM_ICONV configure macro to look for iconv.
    deskutils/fbreader: Let ports framework deal with LIBICONV_PLUG.
    deskutils/ljclive: Override configure test for iconv.
    deskutils/owncloudclient: Add USES=iconv and patch test for iconv.
    devel/aegis: Bump PORTREVISION because it no longer uses libiconv.
    devel/libexplain: Add USES=iconv and override test for iconv.
    devel/sdl20: Override configure test for iconv.
    emulators/vmw: Replace OSVERSION checks with ICONV_LIB checks and include
    <iconv.h> instead of <sys/iconv.h>.
    irc/scrollz: Override configure test for iconv.
    japanese/chasen-base: Override configure test for iconv and patch
    configure so it no longer adds -liconv to linker flags just because it
    happens to be installed.
    japanses/eb: Patch configure test for iconv.
    japanses/eblook: Override configure test for iconv.
    java/jikes: Override configure test for iconv.
    multimedia/transcode: Bump PORTREVISION because only one plugin links with
    libiconv now.
    net/c3270: Override configure test for iconv.
    net/samba4*: Bump PORTREVISION because it no longer uses libiconv.  The
    configure script will always add -liconv to the linker flags when it
    happens to be installed which would be wrong but later on binaries are
    linked with -Wl,--as-needed and the linker discards -liconv because it
    finds iconv*() functions in libc now and no longer in libiconv.
    net-mgmt/icinga-*: Remove dependency on iconv.
    net-mgmt/netxms: Patch configure so it no longer adds -liconv to linker
    flags just because it happens to be installed.
    net/asterisk11: Patch configure so it no longer adds -liconv to linker
    flags just because it happens to be installed.
    net-p2p/transmission-*: Override configure test for iconv.
    www/htmlcxx: Override configure test for iconv.
    www/httrack: Override configure test for iconv.
    www/xapian-omega: Override configure test for iconv.
    x11/mrxvt(-devel): Add USES=iconv and override configure test for iconv.
    x11/x3270: Override configure test for iconv.
    x11-wm/jwm: Override configure test for iconv.
    
    PR:		202838
    Exp-run by:	antoine
    Approved by:	portmgr (antoine)
    922a618b